| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, peter(dot)eisentraut(at)2ndquadrant(dot)com |
| Subject: | Re: More issues with expressions always false (no patch) |
| Date: | 2020-01-08 18:41:55 |
| Message-ID: | eeb53239-e34e-0dbe-ff3d-9c9a60cf7a1c@proxel.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/20/19 10:34 PM, Tom Lane wrote:
> I think the "useless" free
> is cheap insurance against a permanent memory leak, as well as more
> like the coding in nearby functions like RelationGetIndexAttrBitmap.
> I wouldn't change it.
Good point, if there is a pattern it is good to follow it. But I am
pretty sure that the other issue Ranier's static analysis discovered is
a real bug and not just about shaving off a virtually no clock cycles
(but I am not 100% sure my fix is correct). Will submit it to the
commitfest so people can take a look.
Andreas
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2020-01-08 19:09:12 | our checks for read-only queries are not great |
| Previous Message | Tom Lane | 2020-01-08 18:38:12 | Re: xact_start for walsender & logical decoding not updated |