| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Some RELKIND macro refactoring |
| Date: | 2021-12-02 15:56:02 |
| Message-ID: | eeae85ac-dc70-f056-f3b9-a92d44b857ef@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 24.11.21 05:20, Michael Paquier wrote:
> On Mon, Nov 22, 2021 at 11:21:52AM +0100, Peter Eisentraut wrote:
>> On 19.11.21 08:31, Michael Paquier wrote:
>>> Regarding 0001, I find the existing code a bit more self-documenting
>>> if we keep those checks flagInhAttrs() and guessConstraintInheritance().
>>> So I would rather leave these.
>> In that case, the existing check in guessConstraintInheritance() seems
>> wrong, because it doesn't check for RELKIND_MATVIEW. Should we fix that?
>> It's dead code either way, but if the code isn't exercises, then these kinds
>> of inconsistency come about.
> Yeah, this one could be added. Perhaps that comes down to one's taste
> at the end, but I would add it.
Ok, I have committed adding the missing relkind, as you suggest. Patch
v3-0001 is therefore obsolete.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2021-12-02 16:00:32 | Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file |
| Previous Message | Robert Haas | 2021-12-02 15:44:02 | Re: Can I assume relation would not be invalid during from ExecutorRun to ExecutorEnd |