From: | Arne Roland <A(dot)Roland(at)index(dot)de> |
---|---|
To: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "reid(dot)thompson(at)crunchydata(dot)com" <reid(dot)thompson(at)crunchydata(dot)com> |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> |
Subject: | Re: Add the ability to limit the amount of memory that can be allocated to backends. |
Date: | 2022-10-24 15:27:51 |
Message-ID: | ee9486a314a341ec878fd61deadd9d3a@index.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello Reid,
could you rebase the patch again? It doesn't apply currently (http://cfbot.cputube.org/patch_40_3867.log) Thanks!
You mention, that you want to prevent the compiler from getting cute.
I don't think this comments are exactly helpful in the current state. I think probably fine to just omit them.
I don't understand the purpose of the result variable in exceeds_max_total_bkend_mem. What purpose does it serve?
I really like the simplicity of the suggestion here to prevent oom.
I intent to play around with a lot of backends, once I get a rebased patch.
Regards
Arne
________________________________
From: Reid Thompson <reid(dot)thompson(at)crunchydata(dot)com>
Sent: Thursday, September 15, 2022 4:58:19 PM
To: Ibrar Ahmed; pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: reid(dot)thompson(at)crunchydata(dot)com; Justin Pryzby
Subject: Re: Add the ability to limit the amount of memory that can be allocated to backends.
On Thu, 2022-09-15 at 12:07 +0400, Ibrar Ahmed wrote:
>
> The patch does not apply; please rebase the patch.
>
> patching file src/backend/utils/misc/guc.c
> Hunk #1 FAILED at 3664.
> 1 out of 1 hunk FAILED -- saving rejects to file
> src/backend/utils/misc/guc.c.rej
>
> patching file src/backend/utils/misc/postgresql.conf.sample
>
rebased patches attached.
Thanks,
Reid
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2022-10-24 15:32:14 | Re: effective_multixact_freeze_max_age issue |
Previous Message | Frédéric Yhuel | 2022-10-24 15:26:50 | [PATCH] minor optimization for ineq_histogram_selectivity() |