Re: [PATCH] Add CSS to support discoverable ids in the public documentation website

From: Brar Piening <brar(at)gmx(dot)de>
To: Melanie Plageman <melanieplageman(at)gmail(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
Cc: pgsql-www(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: [PATCH] Add CSS to support discoverable ids in the public documentation website
Date: 2023-04-19 21:08:26
Message-ID: ee778f0b-e59b-1bde-87a5-a2d1316d49e3@gmx.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

On 19.04.2023 at 22:21, Melanie Plageman wrote:
> On Wed, Apr 19, 2023 at 4:08 PM Jonathan S. Katz <jkatz(at)postgresql(dot)org> wrote:
>> On 4/13/23 9:41 AM, Brar Piening wrote:
>>> Attached is the (unmodified) patch I initially sent to pgsql-hackers in
>>> [2]. Please see the thread in pgsql-hackers for the discussion so far.
>> I personally like the paperclip given how it's synonymous with "link",
>> but that may also give the illusion that we also automatically copy the
>> link to the clipboard. Perhaps "#" is good enough?
> I find the "#" pretty meaningless and the paper clip a bit silly.
> Personally, I think the link icon is the nicest. David pointed out [3]
> does this, and it is quite visually appealing.

I have no qualifications or whatsoever to comment on the visual design,
so I will not be involved in any bike shedding but please note that the
patch here does not and cannot chose the symbol we are displaying. Being
pure CSS it only changes the default color and visibility of the symbol.
The symbol was part of the xslt modifications in the patch that I sent
to hackers and was commited in commit e2922702a3. If you really think
that changing the symbol is important or useful, you'll probably have to
carry the discussion back to hackers (maybe to the original thread).

Regards,
Brar

In response to

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Stefanie Janine Stölting 2023-04-21 09:27:53 Patch to clean up and add missing GSoC pages
Previous Message Melanie Plageman 2023-04-19 20:21:01 Re: [PATCH] Add CSS to support discoverable ids in the public documentation website