| From: | Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com> |
|---|---|
| To: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: increasing the default WAL segment size |
| Date: | 2017-02-28 04:15:32 |
| Message-ID: | ed647eac-d911-c2cb-5ba0-ae3a25b90f4f@BlueTreble.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/24/17 6:30 AM, Kuntal Ghosh wrote:
> * You're considering any WAL file with a power of 2 as valid. Suppose,
> the correct WAL seg size is 64mb. For some reason, the server
> generated a 16mb invalid WAL file(maybe it crashed while creating the
> WAL file). Your code seems to treat this as a valid file which I think
> is incorrect. Do you agree with that?
Detecting correct WAL size based on the size of a random WAL file seems
like a really bad idea to me.
I also don't see the reason for #2... or is that how initdb writes out
the correct control file?
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
855-TREBLE2 (855-873-2532)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2017-02-28 04:16:38 | Re: Restricting maximum keep segments by repslots |
| Previous Message | Amit Langote | 2017-02-28 04:08:34 | Re: Partitioned tables and relfilenode |