| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Cary Huang <cary(dot)huang(at)highgo(dot)ca>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Logging which local address was connected to in log_line_prefix |
| Date: | 2024-07-08 07:07:16 |
| Message-ID: | ecf99332-ef2f-4715-b769-2f6dc926970c@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 5/24/24 22:33, Greg Sabino Mullane wrote:
> Peter, thank you for the feedback. Attached is a new patch with
> "address" rather than "interface", plus a new default of "local" if
> there is no address. I also removed the questionable comment, and
> updated the commitfest title.
I tried the updated patch and it behaved as expected with [local] being
logged for peer connections and an IP being logged for host connections.
One thing -- the changes in postgresql.conf.sample should use tabs to
match the other lines. The patch uses spaces.
I also find the formatting in log_status_format() pretty awkward but I
guess that will be handled by pgindent.
Regards,
-David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nitin Jadhav | 2024-07-08 07:21:16 | Address the -Wuse-after-free warning in ATExecAttachPartition() |
| Previous Message | Hayato Kuroda (Fujitsu) | 2024-07-08 07:04:40 | RE: Slow catchup of 2PC (twophase) transactions on replica in LR |