From: | "Asko Oja" <ascoja(at)gmail(dot)com> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "Abhijit Menon-Sen" <ams(at)oryx(dot)com>, "Gavin Sherry" <swm(at)alcove(dot)com(dot)au>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCH] "\ef <function>" in psql |
Date: | 2008-07-29 10:56:19 |
Message-ID: | ecd779860807290356i56a998d4ne897d537eaf13073@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Not so sure about omitting OR REPLACE. In my experience it is more often
needed than not. Main argument for omitting might be to protect hackers from
carelesse users :)
On Wed, Jul 23, 2008 at 5:50 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Abhijit Menon-Sen <ams(at)oryx(dot)com> writes:
> > At 2008-07-17 18:28:19 -0400, tgl(at)sss(dot)pgh(dot)pa(dot)us wrote:
> >> It wouldn't take a whole lot to convince me that a pg_get_functiondef
> >> would be useful, although I don't foresee either of those applications
> >> wanting to use it because of their backward-compatibility constraints.
>
> > What would the function return? "CREATE OR REPLACE FUNCTION ..."? Would
> > that be good enough for everyone who might want to call it?
>
> I think I'd go with CREATE FUNCTION for simplicity. It would be easy
> enough for something like \ef to splice in OR REPLACE before shipping
> the command back to the server.
>
> regards, tom lane
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2008-07-29 11:08:44 | Re: patch: Add a separate TRUNCATE permission |
Previous Message | Gregory Stark | 2008-07-29 10:56:17 | Re: [WIP] patch - Collation at database level |