| From: | Evgeny Voropaev <evorop(dot)wiki(at)gmail(dot)com> |
|---|---|
| To: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Evgeny <evorop(at)gmail(dot)com> |
| Cc: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Evgeny Voropaev <evgeny(dot)voropaev(at)tantorlabs(dot)com>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Elimination of the repetitive code at the SLRU bootstrap functions. |
| Date: | 2025-03-12 15:02:07 |
| Message-ID: | ec2eb904-74f8-4665-a372-f77af6c0a572@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Hackers!
Andrey, thank you for your review and remarks.
> Patch adds whitespace errors
Cleaned.
> if (writePage != 0) should be if (writePage)
Done.
> XLogSimpleInsert(int64 simpledata, RmgrId rmid, uint8 info)
> I’d rename function XLogSimpleInsert() to something more descriptive
> and changed arguments order from generic to specific.
The function has been renamed and the parameters have been reordered.
Now we have:
XLogInsertInt64(RmgrId rmid, uint8 info, int64 simpledata)
> Probably, committer has broader view on XLog routines and can decide
> if this function would better belong to SLRU than common XLog stuff.
In accordance with Álvaro's proposal, we want to enclose this function
in the "xloginsert.c" module.
Best regards,
Evgeny Voropaev.
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Elimination-of-the-repetitive-code-at-the-SLRU-bo.patch | text/x-patch | 21.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2025-03-12 15:17:55 | Re: dblink: Add SCRAM pass-through authentication |
| Previous Message | Yura Sokolov | 2025-03-12 14:44:28 | Re: Implement waiting for wal lsn replay: reloaded |