| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Evgeny <evorop(at)gmail(dot)com> |
| Cc: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Evgeny Voropaev <evgeny(dot)voropaev(at)tantorlabs(dot)com>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Elimination of the repetitive code at the SLRU bootstrap functions. |
| Date: | 2025-03-12 06:25:47 |
| Message-ID: | CA70EA21-4272-432A-A162-9FE17E19DDB5@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 11 Mar 2025, at 14:12, Evgeny <evorop(at)gmail(dot)com> wrote:
>
Hi!
Some nits:
Patch adds whitespace errors
.git/rebase-apply/patch:64: trailing whitespace.
* Nullify the page (pageno = 0), don't insert an XLog record, .git/rebase-apply/patch:212: trailing whitespace.
/* .git/rebase-apply/patch:213: trailing whitespace.
* Zero the page; .git/rebase-apply/patch:250: trailing whitespace.
.git/rebase-apply/patch:349: trailing whitespace.
* Nullify the page (pageno = 0), don't insert an XLog record, warning: squelched 10 whitespace errors
warning: 15 lines add whitespace errors.
if (writePage != 0) should be if (writePage)
XLogSimpleInsert(int64 simpledata, RmgrId rmid, uint8 info)
I’d rename function XLogSimpleInsert() to something more descriptive and changed arguments order from generic to specific. Probably, committer has broader view on XLog routines and can decide if this function would better belong to SLRU than common XLog stuff.
Besides this patch seems ready to me.
Thanks!
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2025-03-12 06:26:30 | Re: Parallel heap vacuum |
| Previous Message | David G. Johnston | 2025-03-12 06:08:34 | Re: pg_recvlogical requires -d but not described on the documentation |