| From: | Vik Fearing <vik(at)postgresfriends(dot)org> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Georgios Kokolatos <gkokolatos(at)protonmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl> |
| Subject: | Re: GROUP BY DISTINCT |
| Date: | 2021-03-18 23:55:52 |
| Message-ID: | ea0cc900-174a-0f51-539f-5f51af8b4097@postgresfriends.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs pgsql-hackers |
On 3/19/21 12:52 AM, Tomas Vondra wrote:
>
> On 3/19/21 12:26 AM, Tom Lane wrote:
>> I wrote:
>>> This is gcc 4.5, but hopefully whatever shuts it up will also work on 4.7.
>>> I'll work on figuring that out.
>>
>> Actually, the problem is pretty obvious after comparing this use
>> of foreach_delete_current() to every other one. I'm not sure why
>> the compiler warnings are phrased just as they are, but the fix
>> I just pushed does make 4.5 happy.
>>
>
> Thanks! Yeah, that looks obvious. Funny the older compilers noticed
> this, not the new fancy ones.
+1
I'm glad the buildfarm is so diverse.
--
Vik Fearing
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Doc comments form | 2021-03-20 19:16:01 | "there is no way to insert less than one row" |
| Previous Message | Tomas Vondra | 2021-03-18 23:52:17 | Re: GROUP BY DISTINCT |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-03-19 00:07:10 | Re: Maintaining a list of pgindent commits for "git blame" to ignore |
| Previous Message | Peter Geoghegan | 2021-03-18 23:54:53 | Re: Maintaining a list of pgindent commits for "git blame" to ignore |