Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)?

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tels <nospam-pg-abuse(at)bloodgate(dot)com>, Stephen Froehlich <s(dot)froehlich(at)cablelabs(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Subject: Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)?
Date: 2018-02-01 08:45:50
Message-ID: ea0a3562-fba8-a52d-a31a-71e05bb50837@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-novice

On 02/01/2018 07:26 AM, David Rowley wrote:
> On 30 January 2018 at 14:14, David G. Johnston
> <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
>> This bug has an obvious if annoying work-around and fixing the bug will
>> likely cause people's code, that uses said work-around, to fail. Breaking
>> people's working code in stable release branches is generally a no-no.
>>
>> However, given that this was discovered 4 months after the feature was
>> released suggests to me that we are justified, and community-serving, to
>> back-patch this. Put more bluntly, we can ask for more leeway in the first
>> few patch releases of a new feature since more people will benefit from 5
>> years of a fully-baked feature than may be harmed by said change. We
>> shouldn't abuse that but an obvious new feature bug/oversight like this
>> seems reasonable.
>
> That seems quite rational.
>
> To prevent this getting lost I've added it to the March commitfest [1].
>
> In the commitfest application I've classed it (for now) as a bug fix.
> If that changes then we can alter it in the commitfest app.
>
> [1] https://commitfest.postgresql.org/17/1501/
>

Thank you for taking care of this.

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Konstantin Knizhnik 2018-02-01 08:49:24 Re: [HACKERS] Surjective functional indexes
Previous Message Anton Dignös 2018-02-01 08:43:14 IndexJoin memory problem using spgist and boxes

Browse pgsql-novice by date

  From Date Subject
Next Message Eugene Pirogov 2018-02-02 07:30:04 Can't download .mbox file
Previous Message David Rowley 2018-02-01 06:26:02 Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)?