| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Fix comments in gistxlogDelete, xl_heap_freeze_page and xl_btree_delete |
| Date: | 2023-03-03 16:28:47 |
| Message-ID: | e9e025ca-bf2b-cdcd-3283-3bc7e5ef6d53@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 3/3/23 12:30 PM, Amit Kapila wrote:
> On Thu, Mar 2, 2023 at 6:35 PM Drouvot, Bertrand
> <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>>
>> On 1/6/23 11:05 AM, Drouvot, Bertrand wrote:
>>> Hi hackers,
>>>
>>> Please find attached a patch to $SUBJECT.
>>>
>>> The wrong comments have been discovered by Robert in [1].
>>>
>>> Submitting this here as a separate thread so it does not get lost in the logical decoding
>>> on standby thread.
>>>
>>> [1]: https://www.postgresql.org/message-id/CA%2BTgmoYTTsxP8y6uknZvCBNCRq%2B1FJ4zGbX8Px1TGW459fGsaQ%40mail.gmail.com
>>>
>>> Looking forward to your feedback,
>>>
>>> Regards,
>>>
>>
>> It looks like I did not create a CF entry for this one: fixed with [1].
>>
>> Also, while at it, adding a commit message in V2 attached.
>>
>
> LGTM.
>
Thanks for having looked at it!
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-03-03 16:33:29 | Re: libpq: PQgetCopyData() and allocation overhead |
| Previous Message | Drouvot, Bertrand | 2023-03-03 16:26:31 | Re: Minimal logical decoding on standbys |