| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie>, Jelte Fennema <postgres(at)jeltef(dot)nl>, Michael Paquier <michael(at)paquier(dot)xyz>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Jesse Zhang <sbjesse(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: run pgindent on a regular basis / scripted manner |
| Date: | 2023-08-14 19:58:34 |
| Message-ID: | e97064a9-7f67-ba3d-e7e6-ff87723875d5@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-08-14 Mo 10:04, Peter Eisentraut wrote:
> On 12.08.23 23:14, Andres Freund wrote:
>> It's a somewhat annoying task though, find all the typedefs, add them
>> to the
>> right place in the file (we have an out of order entry right now). I
>> think a
>> script that*adds* (but doesn't remove) local typedefs would make
>> this less
>> painful.
>
> I was puzzled once that there does not appear to be such a script
> available. Whatever the buildfarm does (before it merges it all
> together) should be available locally. Then the workflow could be
>
> type type type
> compile
> update typedefs
> pgindent
> commit
It's a bit more complicated :-)
You can see what the buildfarm does at
<https://github.com/PGBuildFarm/client-code/blob/ec4cf43613a74cb88f228efcde09931cf9fd57e7/run_build.pl#L2562>
It's been somewhat fragile over the years, which most people other than
Tom and I have probably not noticed.
On most platforms it needs postgres to have been installed before
looking for the typedefs.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2023-08-14 20:37:54 | Re: Regarding Contributions |
| Previous Message | Satwik Sharma | 2023-08-14 19:54:44 | Regarding Contributions |