Re: postgres_fdw: support parameterized foreign joins

From: Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
To: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: postgres_fdw: support parameterized foreign joins
Date: 2017-04-07 13:54:17
Message-ID: e93f9de8-5806-98ee-a607-b7af4ad1fcef@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 05.04.2017 12:20, Etsuro Fujita wrote:
>
> Rebased.
>
> Attached is an updated version created on top of the latest patch
> "epqpath-for-foreignjoin" [1].
>
> Other changes:
> * Added a bit more regression tests with FOR UPDATE clause to see if
> CreateLocalJoinPath works well for parameterized foreign join paths.
> * Added/revised comments a bit.
>

Thank you!

> scan_clauses=NIL for a join relation. So, for a join relation we use
> fpinfo->remote_conds and fpinfo->local_conds, instead. (Note that those
> conditions are created at path creation time, ie,
> postgresGetForeignJoinPaths. See foreign_join_ok.)

Oh, I see. I've missed that condition.

Marked the patch as "Ready for Commiter". But the patch should be
commited only after the patch [1].

1.
https://www.postgresql.org/message-id/424933d7-d6bb-4b8f-4e44-1fea212af083%40lab.ntt.co.jp

--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-04-07 13:58:43 Re: src/interfaces/libpq shipping nmake-related Makefiles
Previous Message Heikki Linnakangas 2017-04-07 13:28:13 Re: src/interfaces/libpq shipping nmake-related Makefiles