Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing
Date: 2025-03-29 16:24:58
Message-ID: e852442da35b4f31acc600ed98bbee0f12e65e0c.camel@j-davis.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, 2025-02-28 at 01:16 +0000, Michael Paquier wrote:
> pg_upgrade: Fix inconsistency in memory freeing

> Details
> -------
> https://git.postgresql.org/pg/commitdiff/2a083ab807db6d9e2e0e3aa82ee8f6ff9fc44c8d
>

This seems to have broken the pg_upgrade test when olddump/oldinstall
are set to PG14 or earlier:

stderr:
# Failed test 'check that locales in new cluster match original
cluster'
# at
/home/jdavis/git/postgresql/src/bin/pg_upgrade/t/002_pg_upgrade.pl line
506.
# got: '0|c|C|C|NULL'
# expected: '0|c|C|C|'
# Looks like you failed 1 test of 16.

Looking at the commit, it seems you are escaping NULL as a literal.

Regards,
Jeff Davis

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2025-03-29 18:08:45 pgsql: aio: Implement support for reads in smgr/md/fd
Previous Message Tomas Vondra 2025-03-29 15:49:02 pgsql: amcheck: Fix indentation in verify_gin.c