Re: Update does not move row across foreign partitions in v11

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Derek Hans <derek(dot)hans(at)gmail(dot)com>
Subject: Re: Update does not move row across foreign partitions in v11
Date: 2019-03-08 02:06:55
Message-ID: e8269ccf-ad98-9c59-6bae-2c44c900c12e@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Thanks for the review.

On 2019/03/07 21:35, Etsuro Fujita wrote:
> The patch looks good to me, but one thing I'm wondering is: as suggested
> by David, it would be better to rephrase this mention in the UPDATE
> reference page, in a single commit:
>
> "Currently, rows cannot be moved from a partition that is a foreign table
> to some other partition, but they can be moved into a foreign table if the
> foreign data wrapper supports it."
>
> I don't think it needs to be completely rephrased; it's enough for me to
> rewrite it to something like this:
>
> "Currently, rows cannot be moved from a foreign-table partition to some
> other partition, but they can be moved into a foreign-table partition if
> the foreign data wrapper supports tuple routing."
>
> And to make maintenance work easy, I think it might be better to just put
> this on the limitations section of 5.10. Table Partitioning.  What do you
> think about that?

I agree, so updated the patch this way.

David, can you confirm if the rewritten text reads unambiguous or perhaps
suggest a better wording?

Thanks,
Amit

Attachment Content-Type Size
document-update-row-movement-limitation-v3.patch text/plain 1.6 KB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Julie Nishimura 2019-03-08 02:11:54 Re: partial data migration
Previous Message Ron 2019-03-08 01:59:46 Re: partial data migration

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2019-03-08 02:08:10 Re: Add exclusive backup deprecation notes to documentation
Previous Message Kuroda, Hayato 2019-03-08 01:54:28 RE: ECPG regression with DECLARE STATEMENT support