| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, David Rowley <dgrowleyml(at)gmail(dot)com>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Subject: | Re: Improve list manipulation in several places |
| Date: | 2023-05-08 15:22:28 |
| Message-ID: | e8101b84-7313-654b-1a3f-0cbd270180b7@enterprisedb.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 23.04.23 08:42, Richard Guo wrote:
> Thanks for the suggestion. I've split the patch into two as attached.
> 0001 is just a minor simplification by replacing lfirst(list_head(list))
> with linitial(list). 0002 introduces new functions to reduce the
> movement of list elements in several places so as to gain performance
> improvement and benefit future callers.
These look sensible to me. If you could show some numbers that support
the claim that there is a performance advantage, it would be even more
convincing.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melih Mutlu | 2023-05-08 15:41:26 | Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication |
| Previous Message | Tom Lane | 2023-05-08 14:49:28 | Re: [PATCH] Allow Postgres to pick an unused port to listen |