Re: why doesn't DestroyPartitionDirectory hash_destroy?

On 2019/03/14 16:46, Amit Langote wrote:
> On 2019/03/14 16:32, Kyotaro HORIGUCHI wrote:
>> At Thu, 14 Mar 2019 16:13:23 +0900, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote in <3ad792cd-0805-858e-595c-c09e9d1ce042(at)lab(dot)ntt(dot)co(dot)jp>
>>> Hi,
>>>
>>> I'm curious why DestroyPartitionDirectory doesn't do
>>> hash_destroy(pdir->pdir_hash)?
>>
>> Maybe it is trashed involved in destruction of es_query_cxt or
>> planner_cxt?
>
> Hmm, the executor's partition directory (its hash table) is indeed
> allocated under es_query_cxt. But, the planner's partition directory is
> not allocated under planner_cxt, it appears to be using memory under
> MessageContext.

I forgot to mention that it would be wrong to put it under planner_cxt, as
it's the context for planning a given subquery, whereas a partition
directory is maintained throughout the whole planning.

Thanks,
Amit