Re: Sample rate added to pg_stat_statements

From: Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Sami Imseih <samimseih(at)gmail(dot)com>, Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Sample rate added to pg_stat_statements
Date: 2025-01-23 08:46:29
Message-ID: e738eac5-ad4d-454c-a079-38766e32ce52@tantorlabs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 23.01.2025 08:21, Andrey Borodin wrote:
>> <v11-0001-Allow-setting-sample-ratio-for-pg_stat_statements.patch>
> There’s a typo in the commit message (ratio instead of rate). Besides this the patch looks ready for committer.
>
>
> Best regards, Andrey Borodin.

Fixed. Thank you for review!

I noticed that the code has not enough comments, so I added additional
ones to improve clarity. Additionally, I moved the
update_current_query_sampled() function to the end of the file, as
keeping it between hooks didn’t seem appropriate to me.

All these changes are included in the updated patch (v12), which I have
attached.

The patch is part of the current 2025-01 Commitfest:
https://commitfest.postgresql.org/51/5390/

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.

Attachment Content-Type Size
v12-0001-Allow-setting-sample-ratio-for-pg_stat_statements.patch text/x-patch 10.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Japin Li 2025-01-23 08:46:44 Re: [RFC] Lock-free XLog Reservation from WAL
Previous Message Shlok Kyal 2025-01-23 08:42:40 Re: create subscription with (origin = none, copy_data = on)