Re: improvements in Unicode tables generation code

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: improvements in Unicode tables generation code
Date: 2021-09-28 08:25:20
Message-ID: e6baa40f-a40f-564f-9b45-9ad63bf01f2d@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 20.07.21 13:57, Peter Eisentraut wrote:
>>> Perhaps we should change the script or Makefile so that it doesn't
>>> create all the maps in one go?
>>
>> I agree, either comment it better or just write one file at a time.
>> I'll take another look at that.
>
> Here is a patch that does it one file (pair) at a time.  The other rules
> besides UCS_to_most.pl actually had the same problem, since they produce
> two output files, so running in parallel called each script twice.  In
> this patch, all of that is heavily refactored and works correctly now.
> Note that UCS_to_most.pl already accepted a command-line argument to
> specify which encoding to work with.

Here is an updated patch with a thinko fix that made the previous patch
not actually work.

Attachment Content-Type Size
v2-0001-Make-Unicode-makefile-parallel-safe.patch text/plain 7.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ants Aasma 2021-09-28 09:30:02 Re: storing an explicit nonce
Previous Message bt21tanigaway 2021-09-28 08:06:29 Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented