| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: refactor ownercheck and aclcheck functions |
| Date: | 2022-10-21 19:17:47 |
| Message-ID: | e683d4f1-4b9f-87a6-cd7d-5e1d57e0bdc0@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20.10.22 01:24, Corey Huinker wrote:
> I'd be inclined to remove the highly used ones as well. That way the
> codebase would have more examples of object_ownercheck() for readers to
> see. Seeing the existence of pg_FOO_ownercheck implies that a
> pg_BAR_ownercheck might exist, and if BAR is missing they might be
> inclined to re-add it.
We do have several ownercheck and aclcheck functions that can't be
refactored into this framework right now, so we do have to keep some
special-purpose functions around anyway. I'm afraid converting all the
callers would blow up this patch quite a bit, but it could be done as a
follow-up patch.
> If we do keep them, would it make sense to go the extra step and turn
> the remaining six "regular" into static inline functions or even #define-s?
That could make sense.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2022-10-21 21:24:06 | Re: Collation version tracking for macOS |
| Previous Message | Anton Voloshin | 2022-10-21 17:23:33 | patch suggestion: Fix citext_utf8 test's "Turkish I" with ICU collation provider |