| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Remove some code for old unsupported versions of MSVC |
| Date: | 2020-04-29 09:48:58 |
| Message-ID: | e6612d86-5204-61c2-4cf6-4b1925ee7a43@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2020-04-29 09:05, Amit Kapila wrote:
> On Tue, Oct 8, 2019 at 2:23 PM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>>
>> Remove some code for old unsupported versions of MSVC
>>
>> As of d9dd406fe281d22d5238d3c26a7182543c711e74, we require MSVC 2013,
>> which means _MSC_VER >= 1800. This means that conditionals about
>> older versions of _MSC_VER can be removed or simplified.
>>
>
> I wonder why this has not been backpatched to v12?
It's not a bug fix, so I didn't even consider it.
Also, this patch was part of a series of changes and cleanups in the
Windows builds, so I wouldn't even know offhand whether backpatching it
by itself would result in a clean state.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-04-29 11:54:53 | Re: pgsql: Remove some code for old unsupported versions of MSVC |
| Previous Message | Peter Eisentraut | 2020-04-29 08:15:07 | pgsql: Fix typo |