| From: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Fix some unique identifiers/entities |
| Date: | 2019-05-18 15:40:01 |
| Message-ID: | e63a6171-49f9-ebf4-e80a-896ab6387e28@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello hackers,
I've stumbled upon a misspelled HAVE_ZLIB in a comment and decided to
check all the unique identifiers/entities in the source tree. Using the
balleyeing technique I've processed questionable A* and HAVE_* unicums
(for now). The patches for every one are attached.
1. AExprConst -> AexprConst (an inconsistent case)
2. AlterExtensionOwner_oid - remove (orphaned after 994c36e0)
3. AlterTableDropColumn -> ATExecDropColumn (renamed in 077db40f)
4. ApplySortComparatorFull -> ApplySortAbbrevFullComparator (an internal
inconsistency)
5. arracontjoinsel -> arraycontjoinsel (just a typo)
6. ArrayNItems -> ArrayGetNItems (an internal inconsistency)
7. ArrayRef & ArrayRefState -> SubscriptingRef & SubscriptingRefState
(renamed by 558d77f2)
8. AT_AddOids - remove (orphaned after 578b2297)
10. AtPrepare_Inval - remove (orphaned after efc16ea52)
11. AttachIndexInfo -> IndexAttachInfo (an internal inconsistency)
12. AttributeOffsetGetAttributeNumber - > AttrOffsetGetAttrNumber (an
internal inconsistency)
13. AttInMetaData -> AttInMetadata (an inconsistent case)
14. AUTH_REQ_GSSAPI -> AUTH_REQ_GSS (an internal inconsistency)
15. authenticaion -> authentication (a typo)
16. HAVE__BUILTIN_CLZ -> HAVE__BUILTIN_CLZ (a typo)
17. HAVE_BUILTIN_CLZ -> HAVE__BUILTIN_CLZ (a typo)
18. HAVE_BUILTIN_CTZ -> HAVE__BUILTIN_CLZ (a typo)
18. HAVE_FCVT - remove (survived after ff4628f3)
19. HAVE_FINITE - remove (orphaned after cac2d912)
20. HAVE_RAND_OPENSSL - remove (orphaned after fe0a0b59)
21. HAVE_STRUCT_SOCKADDR_UN - remove (survived after ff4628f3)
22. HAVE_SYSCONF - remove (survived after ff4628f3)
23. HAVE_ZLIB -> HAVE_LIBZ (a typo)
I hope you will find it useful. If so, I can continue this work.
Best regards,
Alexander
| Attachment | Content-Type | Size |
|---|---|---|
| AExprConst.patch | text/x-patch | 601 bytes |
| AlterExtensionOwner_oid.patch | text/x-patch | 487 bytes |
| AlterTableDropColumn.patch | text/x-patch | 631 bytes |
| ApplySortComparatorFull.patch | text/x-patch | 744 bytes |
| arracontjoinsel.patch | text/x-patch | 803 bytes |
| ArrayNItems.patch | text/x-patch | 488 bytes |
| ArrayRef.patch | text/x-patch | 6.6 KB |
| AT_AddOids.patch | text/x-patch | 656 bytes |
| AtPrepare_Inval.patch | text/x-patch | 408 bytes |
| AttachIndexInfo.patch | text/x-patch | 465 bytes |
| AttInMetaData.patch | text/x-patch | 588 bytes |
| AttributeOffsetGetAttributeNumber.patch | text/x-patch | 410 bytes |
| AUTH_REQ_GSSAPI.patch | text/x-patch | 601 bytes |
| authenticaion.patch | text/x-patch | 603 bytes |
| HAVE__BUILTIN_CLZ.patch | text/x-patch | 404 bytes |
| HAVE_BUILTIN_CLZ.patch | text/x-patch | 571 bytes |
| HAVE_BUILTIN_CTZ.patch | text/x-patch | 613 bytes |
| HAVE_FCVT.patch | text/x-patch | 477 bytes |
| HAVE_FINITE.patch | text/x-patch | 441 bytes |
| HAVE_RAND_OPENSSL.patch | text/x-patch | 442 bytes |
| HAVE_STRUCT_SOCKADDR_UN.patch | text/x-patch | 535 bytes |
| HAVE_SYSCONF.patch | text/x-patch | 468 bytes |
| HAVE_ZLIB.patch | text/x-patch | 491 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2019-05-18 15:43:29 | Re: Multivariate MCV stats can leak data to unprivileged users |
| Previous Message | Tom Lane | 2019-05-18 15:19:06 | Re: Segfault on ANALYZE in SERIALIZABLE isolation |