Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench
Date: 2021-06-25 01:36:53
Message-ID: e5cd9952-bbe8-958c-8606-5af59d622745@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


On 6/24/21 8:26 PM, Michael Paquier wrote:
> (Forgot to add Andrew in CC, now done)
>
> On Fri, Jun 25, 2021 at 08:51:19AM +0900, Michael Paquier wrote:
>> Andrew, what's the format of the per-thread logs generated on this
>> host when running the commands? I'd bet that the checks for the
>> client IDs are right, but that some parts of the regex are too picky
>> when it comes to this host.
> I have tested that on my own Windows host using MSVC and Active Perl,
> and those tests pass. I am not sure what's happening here. A simple
> way to figure out what's going on would be to make the tests more
> talkative and show up the logs that don't match.

That's not really an equivalent test. I'm taking a look

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2021-06-25 01:53:59 Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench
Previous Message Michael Paquier 2021-06-25 00:57:19 pgsql: Add more debugging information with log checks in TAP tests of p

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-06-25 01:53:59 Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench
Previous Message Peter Geoghegan 2021-06-25 01:33:59 Re: Using indexUnchanged with nbtree