| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com>, Hannu Krosing <hannuk(at)google(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, Atsushi Torikoshi <atorik(at)gmail(dot)com>, Tatsuro Yamada <tatsuro(dot)yamada(dot)tf(at)nttcom(dot)co(dot)jp>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Evgeny Efimkin <efimkin(at)yandex-team(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view? |
| Date: | 2021-04-23 10:04:48 |
| Message-ID: | e5512912-eac9-b163-df2b-e2601ce06d27@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/04/23 18:46, Magnus Hagander wrote:
> On Fri, Apr 23, 2021 at 9:10 AM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>>
>>
>>
>> On 2021/04/22 18:23, Julien Rouhaud wrote:
>>> On Thu, Apr 22, 2021 at 12:28:11AM +0900, Fujii Masao wrote:
>>>>
>>>> I found another small issue in pg_stat_statements docs. The following
>>>> description in the docs should be updated so that toplevel is included?
>>>>
>>>>> This view contains one row for each distinct database ID, user ID and query ID
>>>
>>> Indeed! I'm adding Magnus in Cc.
>>>
>>> PFA a patch to fix at, and also mention that toplevel will only
>>> contain True values if pg_stat_statements.track is set to top.
>>
>> Thanks for the patch! LGTM.
>
> Agreed, in general. But going by the example a few lines down, I
> changed the second part to:
> True if the query was executed as a top level statement
> + (if <varname>pg_stat_statements.track</varname> is set to
> + <literal>all</literal>, otherwise always false)
Isn't this confusing? Users may mistakenly read this as that the toplevel
column always indicates false if pg_stat_statements.track is not "all".
> (changes the wording, but also the name of the parameter is
> pg_stat_statements.track, not pg_stat_statements.toplevel (that's the
> column, not the parameter). Same error in the commit msg except there
> you called it pg_stat_statements.top - but that one needed some more
> fix as well)
>
> With those changes, applied. Thanks!
Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2021-04-23 10:11:31 | Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view? |
| Previous Message | Amit Kapila | 2021-04-23 10:02:07 | Re: [bug?] Missed parallel safety checks, and wrong parallel safety |