From: | Marko Kreen <markokr(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Kurt Harriman <harriman(at)acm(dot)org>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Patch: Remove gcc dependency in definition of inline functions |
Date: | 2009-12-16 16:24:34 |
Message-ID: | e51f66da0912160824p40f596ceya129d520ae41c2ba@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 12/16/09, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Marko Kreen <markokr(at)gmail(dot)com> writes:
>
> > So the plain-C89 compilers would be downgraded to "second-class"
> > targets, not worth getting max performance out of them.
>
>
> Hm? Failing to inline is already a performance hit, which is why
> Kurt got interested in this in the first place.
>
> I think you're way overthinking this. Where we started was just
> a proposal to try to expand the set of inline-ing compilers beyond
> "gcc only". I don't see why we need to do anything but that. The
> code is fine as-is except for the control #ifdefs.
My proposal is basically about allowing more widespread use of
"static inline". That is - "static inline" does not need to be
paired with equivalent macro.
But if C89 compilers are still project's primary target, then this
cannot be allowed.
--
marko
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-12-16 16:35:53 | Re: [ADMIN] recovery is stuck when children are not processing SIGQUIT from previous crash |
Previous Message | Tom Lane | 2009-12-16 16:21:59 | Re: Patch: Remove gcc dependency in definition of inline functions |