Re: [PATCH 2/2] [libpq] Try to avoid manually masking SIGPIPEs on every send()

From: Marko Kreen <markokr(at)gmail(dot)com>
To: Jeremy Kerr <jk(at)ozlabs(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [PATCH 2/2] [libpq] Try to avoid manually masking SIGPIPEs on every send()
Date: 2009-06-10 11:26:50
Message-ID: e51f66da0906100426g35f35ea5l12d20f5fb834d639@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 6/10/09, Jeremy Kerr <jk(at)ozlabs(dot)org> wrote:
> + int optval;

> + if (!setsockopt(conn->sock, SOL_SOCKET, SO_NOSIGPIPE,
> + (char *)&optval, sizeof(optval)))

optval seems used without initialization.

But generally, I like it. +1

--
marko

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gregory Stark 2009-06-10 11:38:34 Re: Plan time Improvement - 64bit bitmapset
Previous Message Andres Freund 2009-06-10 10:54:49 Re: Plan time Improvement - 64bit bitmapset