From: | "Marko Kreen" <markokr(at)gmail(dot)com> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "Magnus Hagander" <magnus(at)hagander(dot)net>, "Jan Wieck" <JanWieck(at)yahoo(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Skytools committed without hackers discussion/review |
Date: | 2007-10-10 19:59:26 |
Message-ID: | e51f66da0710101259p7472259fye8ec375bb42992da@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 10/10/07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Marko Kreen" <markokr(at)gmail(dot)com> writes:
> > On 10/10/07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> * Why is txid_current_snapshot() excluding subtransaction XIDs? That
> >> might be all right for the current uses in Slony/Skytools, but it seems
> >> darn close to a bug for any other use.
> > ...
> > But I agree, supporting subtransactions makes the API more
> > universal. And it wouldn't break Slony/PgQ current usage.
>
> After looking at this more closely, I think txid_current_snapshot is
> okay as is, but is_visible_txid is probably buggy: the latter should be
> folding subtransaction IDs to top-transaction IDs, no? If not, why not?
> I hope the answer is "no" because otherwise the code will be at huge risk
> from truncation of pg_subtrans, but it's not apparent why this behavior
> is okay.
Could you describe bit more? The is_visible_txid() works
on data returned by txid_current_snapshot()? How can there
be any subtrans id's if txid_current_snapshot() wont return
them?
The basic idea is - only txid_current() and txid_current_snapshot()
communicate with backend, rest of functions work on data
returned by them.
--
marko
From | Date | Subject | |
---|---|---|---|
Next Message | Gregory Stark | 2007-10-10 20:02:30 | Re: Skytools committed without hackers discussion/review |
Previous Message | Tom Lane | 2007-10-10 19:49:22 | Re: Skytools committed without hackers discussion/review |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-10-10 20:00:36 | Re: full text search in 8.3 |
Previous Message | Kevin Grittner | 2007-10-10 19:51:14 | Re: Timezone database changes |