Re: Skytools committed without hackers discussion/review

From: "Marko Kreen" <markokr(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, "Magnus Hagander" <magnus(at)hagander(dot)net>, "Michael Glaesemann" <grzm(at)seespotcode(dot)net>, "Bruce Momjian" <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Skytools committed without hackers discussion/review
Date: 2007-10-10 18:22:28
Message-ID: e51f66da0710101122g2d330b24wa08ec790a58088e4@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 10/10/07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Joshua D. Drake" <jd(at)commandprompt(dot)com> writes:
> > If it doesn't need to be in core, in certainly has zero need to be in
> > contrib and can push to pgFoundry.
>
> One advantage of having it in contrib is buildfarm testing, as indeed we
> already found out ... although it's true that *keeping* it there now
> that it passes probably won't teach us too much more.
>
> But I think the argument that was being made was mostly that the Slony
> and Skytools projects would find it easier to depend on a contrib module
> than on something that has to be fetched separately from pgfoundry.
> Now they could work around that by including copies of the pgfoundry
> project in their own distributions, but then they have a collision
> problem if someone tries to install both together. (I have no idea how
> likely that is, though; it might not be a big problem in practice?)

Well, if it is kicked from /contrib now, one way we could handle
it is by shipping the same module inside both skytools/slony.

That has obvious conflict problems.

Unfortunately the problem has very easy fix - each one keeps
using it's current module. Very easy, no work required.

But that also scratches the common API possibility.

--
marko

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Hannu Krosing 2007-10-10 18:25:54 Re: Skytools committed without hackers discussion/review
Previous Message Hannu Krosing 2007-10-10 18:16:48 Re: Skytools committed without hackers discussion/review

Browse pgsql-hackers by date

  From Date Subject
Next Message Hannu Krosing 2007-10-10 18:25:54 Re: Skytools committed without hackers discussion/review
Previous Message Hannu Krosing 2007-10-10 18:16:48 Re: Skytools committed without hackers discussion/review