| From: | "Marko Kreen" <markokr(at)gmail(dot)com> |
|---|---|
| To: | "Jonathan Gray" <jon5pg(at)streamy(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, dmitry(at)taurussoft(dot)org |
| Subject: | Re: Pl/pgsql functions causing crashes in 8.2.2 |
| Date: | 2007-02-06 10:33:24 |
| Message-ID: | e51f66da0702060233y6a6b77bes28c6a157d3f5df9a@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/6/07, Marko Kreen <markokr(at)gmail(dot)com> wrote:
> Indeed, the code can crash on NULL values as the NULL checks
> are missing or wrong in the functions. Actually all the various
> functions except newid() should be declared STRICT IMMUTABLE
> thus immidiately avoiding problems with NULLs.
>
> Could you reproduce the crash with this change? I'll try
> to play with this myself too.
STRICT IMMUTABLE fixed the crash for me so seems it was bug
in the module. Although it did not happen in 8.2.1 so seems
some change in 8.2.2 made it trigger.
Attached is a patch for uniqueindent-0.2 that removes the
buggy checks and makes functions STRICT IMMUTABLE.
--
marko
| Attachment | Content-Type | Size |
|---|---|---|
| null.fix.diff | application/octet-stream | 3.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2007-02-06 10:45:13 | Re: Bitmap index thoughts |
| Previous Message | Heikki Linnakangas | 2007-02-06 10:28:45 | Re: Dead code in _bt_split? |