From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-committers(at)postgresql(dot)org, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Record full paths of programs sought by "configure". |
Date: | 2017-08-07 20:32:22 |
Message-ID: | e5114c3e-b026-495c-6249-a8ebbef4d632@2ndQuadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 08/07/2017 04:20 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
>> On 08/07/2017 04:07 PM, Tom Lane wrote:
>>> Sorry, I was imprecise. What I'm suggesting is that you drop the
>>> runtime PATH-foolery and instead put this in configure's environment:
>>>
>>> PROVE=$perlpathdir/prove
>>>
>>> Otherwise you're basically lying to configure about what you're going
>>> to use, and that's always going to break eventually.
>> Hmm, you're saying this should work now? OK, I'll try it when I get a
>> minute to spare.
> I'm pretty sure it's always worked, at least in the sense that you could
> override what configure would put into Makefile.global that way. I'm not
> quite clear on whether providing an exact path to "prove" there is enough
> to fix your problem. If we have any places where we need to invoke the
> corresponding version of "perl", then we have more things to fix.
I'm pretty sure that's all we need. But we can find out ;-)
>
>>> Hm, yeah, the IPC::Run test would need to deal with this as well.
>>> A PROVE_PERL environment variable is one way. Or maybe simpler,
>>> just skip the probe for IPC::Run if PROVE has been specified
>>> externally; assume the user knows what he's doing in that case.
>> WFM
> OK, I'll go make that happen.
>
>
OK, thanks.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-08-07 20:42:35 | pgsql: Skip test for IPC::Run if user is overriding our search for PROV |
Previous Message | Tom Lane | 2017-08-07 20:20:46 | Re: pgsql: Record full paths of programs sought by "configure". |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2017-08-07 20:40:33 | max_files_per_processes vs others uses of file descriptors |
Previous Message | Peter Geoghegan | 2017-08-07 20:21:19 | Re: Crash report for some ICU-52 (debian8) COLLATE and work_mem values |