| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Newline after --progress report |
| Date: | 2020-08-17 07:14:38 |
| Message-ID: | e4759a4d-4cf7-ca08-f0b8-d1cbd4721dc7@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 14/08/2020 16:51, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>> Attached is a patch to fix this, as well as a similar issue in
>> pg_checksums. pg_basebackup and pgbench also print progres reports like
>> this, but they seem correct to me.
>
> I wonder whether it'd be better to push the responsibility for this
> into progress_report(), by adding an additional parameter "bool last"
> or the like. Then the callers would not need such an unseemly amount
> of knowledge about what progress_report() is doing.
Good point. Pushed a patch along those lines.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2020-08-17 07:55:13 | Re: Commit/abort WAL records with dropped rels missing XLR_SPECIAL_REL_UPDATE |
| Previous Message | Michael Paquier | 2020-08-17 07:00:17 | Re: Commit/abort WAL records with dropped rels missing XLR_SPECIAL_REL_UPDATE |