| From: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
|---|---|
| To: | David Zhang <david(dot)zhang(at)highgo(dot)ca>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add inline comments to the pg_hba_file_rules view |
| Date: | 2023-09-09 20:36:10 |
| Message-ID: | e42ed34a-8d07-c4bd-61d3-cb4ee5a79906@uni-muenster.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi David
On 09.09.23 01:52, David Zhang wrote:
> This is a very useful feature. I applied the patch to the master
> branch, and both make check and make check-world passed without any
> issues.
>
Thanks for reviewing this patch!
>
> Since "only the first #" and "any leading spaces" are removed, IMO, it
> can be more accurate to say,
>
> Text after the first <literal>#</literal> comment character in the end
> of a valid <literal>pg_hba.conf</literal> entry, if any
>
I agree.
v2 attached includes your suggestion. Thanks!
Jim
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-inline-comments-to-the-pg_hba_file_rules-view.patch | text/x-patch | 10.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-09-09 22:56:42 | Re: BUG #18097: Immutable expression not allowed in generated at |
| Previous Message | David Steele | 2023-09-09 20:03:37 | Re: Add const qualifiers |