The varnullingrels bitmapset is not only about outer joins

From: Andrei Lepikhov <lepihov(at)gmail(dot)com>
To: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Richard Guo <guofenglinux(at)gmail(dot)com>
Subject: The varnullingrels bitmapset is not only about outer joins
Date: 2025-04-10 07:40:28
Message-ID: e4065516-e9a3-4730-aa99-698c2f909dcc@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

designing things upon fresh master I found that varnullingrels contains
numbers that is out of the outer joins index range.
Anywhere in documentation I see that this field contains outer join
relids. But after the 247dea8 it simply isn't true.
So, I propose at least to change comments (see attachment). Since the
doc was out of scope, I wonder if someone analysed the impact of this
change on the whole optimiser logic.

--
regards, Andrei Lepikhov

Attachment Content-Type Size
fix.diff text/x-patch 1.7 KB

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2025-04-10 08:16:52 Re: 64 bit numbers vs format strings
Previous Message Thomas Munro 2025-04-10 07:20:17 Re: Cannot find a working 64-bit integer type on Illumos