| From: | Jim Nasby <jim(dot)nasby(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tristan Partin <tristan(at)neon(dot)tech>, John Naylor <johncnaylorls(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add BF member koel-like indentation checks to SanityCheck CI |
| Date: | 2024-01-09 21:50:14 |
| Message-ID: | e3b49e37-fb4c-485f-9f0a-4f1d49b9a314@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/9/24 3:20 PM, Tom Lane wrote:
> In short, I don't think that putting this into CI is the answer.
> Putting it into committers' standard workflow is a better idea,
> if we can get all the committers on board with that.
FWIW, that's the approach that go takes - not only for committing to go
itself, but it is *strongly* recommended[1] that anyone writing any code
in go makes running `go fmt` a standard part of their workflow. In my
experience, it makes collaborating noticably easier because you never
need to worry about formatting differences. FYI, vim makes this easy via
vim-autoformat[2] (which also supports line-by-line formatting if the
format tool allows it); presumably any modern editor has similar support.
1: Literally 3rd item at https://go.dev/doc/effective_go
2: https://github.com/vim-autoformat/vim-autoformat
--
Jim Nasby, Data Architect, Austin TX
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-01-09 22:15:10 | Re: Add BF member koel-like indentation checks to SanityCheck CI |
| Previous Message | Daniel Gustafsson | 2024-01-09 21:42:20 | Re: Add BF member koel-like indentation checks to SanityCheck CI |