Re: Improve error messages for database object stats manipulation functions during recovery

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Maxim Orlov <orlovmg(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Improve error messages for database object stats manipulation functions during recovery
Date: 2024-11-15 17:37:16
Message-ID: e33e7a8a-6f79-47b0-ad3e-85bab93f6bca@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2024/11/15 20:59, Maxim Orlov wrote:
> +1 for the patch.
>
> Recently, one of our customer have tried to upgrade the replica, and, obviously, failed. I don't remember the exact error message, but for him it was not so clear that server is in recovery. Explicitly declaring error is the way to go in my view.
>
> So, I consider this patch useful. Overall, looks good to me.

Thanks for the review!

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2024-11-15 17:40:01 Re: logical replication: restart_lsn can go backwards (and more), seems broken since 9.4
Previous Message Fujii Masao 2024-11-15 17:36:54 Re: Improve error messages for database object stats manipulation functions during recovery