From: | Ivan Kush <ivan(dot)kush(at)tantorlabs(dot)com> |
---|---|
To: | m(dot)litsarev(at)postgrespro(dot)ru |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pg_stat_statements: improve loading and saving routines for the dump file |
Date: | 2025-01-21 15:46:41 |
Message-ID: | e3071cfc-7a9e-4476-81fd-8ff1095baabd@tantorlabs.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
What does this patch give on aglobal scale? Does it save much memory or
increase performance? How many times?
On 1/21/25 13:51, m(dot)litsarev(at)postgrespro(dot)ru wrote:
>> // Mutex should be last field, as this field isn't copied to dump file
> Updated.
>
>> 2) You didn't take into account the upgrade. Saved in Postgres with
>> this byte and try to load in version without this byte.
> The PGSS_DUMP_FILE format is defined by PGSS_FILE_HEADER magic number
> (the first four bytes in the dump file). Once they does not coinside
> (when the file is being read) the statistics are not loaded from the
> dump file and set to zero and the irrelevant dump file is skipped.
> This is the actual behaviour implemented in the code.
>
> Respectfully,
>
> Mikhail Litsarev,
> Postgres Professional: https://postgrespro.com
--
Best wishes,
Ivan Kush
Tantor Labs LLC
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2025-01-21 15:48:56 | Re: [PATCH] Add roman support for to_number function |
Previous Message | jian he | 2025-01-21 15:37:13 | Re: Statistics Import and Export |