| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Refactoring postmaster's code to cleanup after child exit |
| Date: | 2024-09-10 22:35:35 |
| Message-ID: | e2lvootbrfb35ufugjdwwk77sa7ff6vyhaygtbdxwcnhmpjdkk@ankqkqknlrx7 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2024-09-10 13:33:36 -0400, Robert Haas wrote:
> On Tue, Sep 10, 2024 at 12:59 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > I still think that we'd be better off to just return an error to the client in
> > postmaster, rather than deal with this dead-end children mess. That was
> > perhaps justified at some point, but now it seems to add way more complexity
> > than it's worth. And it's absurdly expensive to fork to return an error. Way
> > more expensive than just having postmaster send an error and close the socket.
>
> The tricky case is the one where the client write() -- or SSL_write() -- blocks.
Yea, SSL definitely does make it harder. But it's not exactly rocket science
to do non-blocking SSL connection establishment. After all, we do manage to
do so in libpq...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2024-09-10 22:38:38 | Re: Use read streams in pg_visibility |
| Previous Message | Michael Paquier | 2024-09-10 22:33:31 | Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible |