| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Consistent coding for the naming of LR workers |
| Date: | 2023-07-12 11:34:56 |
| Message-ID: | e2b3cdb7-adb5-6c2a-d973-3265adcef9bb@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 21.06.23 09:18, Alvaro Herrera wrote:
> That is a terrible pattern in relatively new code. Let's get rid of it
> entirely rather than continue to propagate it.
>
>> So, I don't think it is fair to say that these format strings are OK
>> for the existing HEAD code, but not OK for the patch code, when they
>> are both the same.
>
> Agreed. Let's remove them all.
This is an open issue for PG16 translation. I propose the attached
patch to fix this. Mostly, this just reverts to the previous wordings.
(I don't think for these messages the difference between "apply worker"
and "parallel apply worker" is all that interesting to explode the
number of messages. AFAICT, the table sync worker case wasn't even
used, since callers always handled it separately.)
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-untranslatable-error-message-assembly.patch | text/plain | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2023-07-12 11:47:51 | Re: Testing autovacuum wraparound (including failsafe) |
| Previous Message | Pavel Luzanov | 2023-07-12 10:21:42 | Re: psql: Add role's membership options to the \du+ command |