| From: | Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru> |
|---|---|
| To: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Cc: | Zhihong Yu <zyu(at)yugabyte(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Push down time-related SQLValue functions to foreign server |
| Date: | 2021-08-20 07:13:30 |
| Message-ID: | e24c6093a0e248d4d2eaf19b04d207d5@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi.
Ranier Vilela писал 2021-08-19 14:01:
> Em qui., 19 de ago. de 2021 às 07:50, Zhihong Yu <zyu(at)yugabyte(dot)com>
>> Hi,
>> For 0001 patch:
>>
>> + if ((s->op != SVFOP_CURRENT_TIMESTAMP) &&
>> + (s->op != SVFOP_CURRENT_TIMESTAMP_N) &&
>> + (s->op != SVFOP_CURRENT_TIME) &&
>> ...
>>
>> The above check appears more than once. If extracted into a helper
>> method, it would help reduce duplicate and make the code more
>> readable.
>
> Perhaps in a MACRO?
Changed this check to a macro, also fixed condition in
is_foreign_param() and added test for it.
Also fixed comment in prepare_query_params().
--
Best regards,
Alexander Pyhalov,
Postgres Professional
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-SQLValue-functions-pushdown.patch | text/x-diff | 17.2 KB |
| 0002-now-pushdown.patch | text/x-diff | 6.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-08-20 07:23:56 | Re: pg_veryfybackup can fail with a valid backup for TLI > 1 |
| Previous Message | Kyotaro Horiguchi | 2021-08-20 06:33:37 | Re: pg_veryfybackup can fail with a valid backup for TLI > 1 |