Re: pgindent vs. pgperltidy command-line arguments

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent vs. pgperltidy command-line arguments
Date: 2023-06-21 09:09:02
Message-ID: e20c444f-695c-d0c2-2153-65f54474d847@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 20.06.23 17:38, Andrew Dunstan wrote:
>>> +1, although I wonder if we shouldn't follow pgindent's new lead
>>> and require some argument(s).
>>
>> That makes sense to me.  Here is a small update with this behavior
>> change and associated documentation update.
>
> I'm intending to add some of the new pgindent features to pgperltidy.
> Preparatory to that here's a rewrite of pgperltidy in perl - no new
> features yet but it does remove the hardcoded path, and requires you to
> pass in one or more files / directories as arguments.

Are you planning to touch pgperlcritic and pgperlsyncheck as well? If
not, part of my patch would still be useful. Maybe I should commit my
posted patch for PG16, to keep consistency with pgindent, and then your
work would presumably be considered for PG17.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julian Markwort 2023-06-21 09:11:55 Re: [BUG] recovery of prepared transactions during promotion can fail
Previous Message Kyotaro Horiguchi 2023-06-21 08:54:59 Re: ProcessStartupPacket(): database_name and user_name truncation