Re: Enable data checksums by default

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Tomas Vondra <tomas(at)vondra(dot)me>, Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Michael Banck <mbanck(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Enable data checksums by default
Date: 2025-04-24 11:26:04
Message-ID: e181610c-443d-4dcb-b921-94388227a723@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 23.04.25 00:24, Tomas Vondra wrote:
>> The patch that flips the default has been committed.
>>
>> I also started a PG18 open items page and made a note that we follow up
>> on the upgrade experience, as was discussed in this thread.
>>
>> https://wiki.postgresql.org/wiki/PostgreSQL_18_Open_Items
>>
> Regarding the open item, can someone explain what exactly are we
> planning to evaluate mid-beta?

If you have a PG <=17 installation without checksums (the default), and
you do the usual upgrade procedure to PG 18 involving initdb +
pg_upgrade, then pg_upgrade will reject the upgrade, because the
checksum settings don't match. The workaround is to run initdb with
--no-data-checksums and try again.

That's probably not all that bad, but if this is all below a bunch of
layers of scripts, users will have to do some work on their end to get
this working smoothly.

The point of the open item was (a) to make sure this is adequately
documented, for instance in the release notes, (b) to think about
technological solutions to simplify this, such as [0], and (c) to just
check the general feedback.

Nothing from [0] ended up being committed, so that part of obsolete.
The action for beta1 is (a). And then for (c) perhaps monitor the
feedback between beta1 and beta2.

[0]:
https://www.postgresql.org/message-id/flat/57957aca-3eae-4106-afb2-3008122b9950%40eisentraut.org

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2025-04-24 11:30:54 Re: Disallow redundant indexes
Previous Message Andrey Borodin 2025-04-24 11:20:52 Re: [PATCH] dynahash: add memory allocation failure check