Re: [PATCH] pg_stat_statements dealloc field ignores manual deallocation

From: Andrei Zubkov <zubkov(at)moonset(dot)ru>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] pg_stat_statements dealloc field ignores manual deallocation
Date: 2021-03-22 09:06:15
Message-ID: e0904bf7a92beeefdd17a773212514bb84e91bed.camel@moonset.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 2021-03-19 at 22:15 +0800, Julien Rouhaud wrote:
> I disagree. The point of that field is to help users configuring
> pg_stat_statements.max, as evictions have a huge overhead in many
> workloads.
>
> If users remove entries for some reasons, we don't have to give the
> impression
> that pg_stat_statements.max is too low and that it should be
> increased,
> especially since it requires a restart.
>
Ok.
But when we are collecting aggregated statistics on pg_stat_statememts
periodically it would be great to know about every deallocation
happened. Maybe we need to add another counter for manual deallocations
tracking?

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrei Zubkov 2021-03-22 09:07:48 [PATCH] Tracking statements entry timestamp in pg_stat_statements
Previous Message Konstantin Knizhnik 2021-03-22 09:05:53 Re: Built-in connection pooler