Re: [ psql - review request ] review request for \d+ tablename, \d+ indexname indenting

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: 쿼리트릭스 <querytricks2023(at)gmail(dot)com>, Cary Huang <cary(dot)huang(at)highgo(dot)ca>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [ psql - review request ] review request for \d+ tablename, \d+ indexname indenting
Date: 2023-09-13 13:48:50
Message-ID: e08ddb6f-ac12-33d9-a932-f4f13a0d7899@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12.09.23 09:27, 쿼리트릭스 wrote:
> Thank you for letting me know more about the test method.
> As you said, we applied the patch using git diff and created a test case
> on the src/test/regress/sql.

Because of the change of the psql output, a lot of existing test cases
are now failing. You should run "make check" and fix up the failures.
Also, your new test file "subpartition_indentation" isn't actually run
because it was not added to src/test/regress/parallel_schedule. I
suspect you probably don't want to add a new test file for this but
instead see if the existing tests cover this case.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2023-09-13 13:52:17 RE: [PoC] pg_upgrade: allow to upgrade publisher node
Previous Message Daniel Gustafsson 2023-09-13 13:28:18 Re: Redundant Unique plan node for table with a unique index