| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Joe Conway <mail(at)joeconway(dot)com>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Apply RLS policies to partitioned tables. |
| Date: | 2017-06-13 04:20:15 |
| Message-ID: | e056d585-35db-f09d-976f-30fc32776e8a@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2017/06/12 22:46, Tom Lane wrote:
> Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> writes:
>> How about something like the attached? The patch makes
>> mtstate->mt_plans[0] to be passed for all invocations of ExecInitQual() on
>> WithCheckOption.qual that is being initialized for each partition.
>
> Well, the question then is whether that behaves correctly. Where it would
> matter is if the WCO qual contains a SubPlan, because you'd be adding
> multiple instances of the subplan to the PlanState's list. I think it's
> probably all right, but it might be wise to add a test case where there
> is such a subplan.
>
> Spacing and comment wording seem a bit random in this, too.
Was about to send the updated patch, but noticed that you already
committed it after adding the test. Thanks a lot.
Regards,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-06-13 12:56:51 | pgsql: Prevent copying default collation |
| Previous Message | Tom Lane | 2017-06-13 03:30:05 | pgsql: Fix confusion about number of subplans in partitioned INSERT set |