| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Dave Page <dpage(at)pgadmin(dot)org> |
| Subject: | Re: tests fail on windows with default git settings |
| Date: | 2024-07-07 10:30:57 |
| Message-ID: | e006b6a2-2f8e-4463-a58e-09cd51280432@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024-07-07 Su 1:26 AM, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
>> Do we want to support checking out with core.autocrlf?
> -1. It would be a constant source of breakage, and you could never
> expect that (for example) making a tarball from such a checkout
> would match anyone else's results.
Yeah, totally agree.
>> If we do not want to support that, ISTM we ought to raise an error somewhere?
> +1, if we can figure out how.
>
>
ISTM the right fix is probably to use PG_BINARY_R mode instead of "r"
when opening the files, at least in the case if the test_json_parser tests.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2024-07-07 10:57:17 | Optimize WindowAgg's use of tuplestores |
| Previous Message | Dmitry Dolgov | 2024-07-07 10:21:26 | Re: Pluggable cumulative statistics |