| From: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: partition tree inspection functions |
| Date: | 2018-07-27 12:21:57 |
| Message-ID: | dfd06fa1-ddb0-3dda-fa2f-8651fc52a174@redhat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Amit,
On 07/26/2018 10:33 PM, Amit Langote wrote:
> Optional parameter sounds good, so made it get_partition_level(regclass [
> , regclass ]) in the updated patch. Although, adding that argument is not
> without possible surprises its result might evoke. Like, what happens if
> you try to find the level of the root table by passing a leaf partition
> oid for the root table argument, or pass a totally unrelated table for the
> root table argument. For now, I've made the function return 0 for such cases.
>
As 0 is a valid return value for root nodes I think we should use -1
instead for these cases.
Otherwise looks good.
Best regards,
Jesper
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Kuzmenkov | 2018-07-27 12:26:03 | Re: Removing unneeded self joins |
| Previous Message | Fabien COELHO | 2018-07-27 11:53:50 | Re: pgbench - very minor bug fix on hash() missing argument |