Re: SELECT x'00000000F'::int leading zeros causes "integer out of range"

On 25/02/17 08:39, John McKown wrote:
> On Fri, Feb 24, 2017 at 1:25 PM, David G. Johnston
> <david(dot)g(dot)johnston(at)gmail(dot)com <mailto:david(dot)g(dot)johnston(at)gmail(dot)com>>wrote:
>
> On Friday, February 24, 2017, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us
> <mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us>> wrote:
>
> Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
> > Is this expected behavior ?
> > ts=# SELECT x'00000000F'::int;
> > ERROR: 22003: integer out of range
> > LOCATION: bittoint4, varbit.c:1575
>
> Yes. The provided operation is "convert a bitstring of up to
> 32 bits
> to an integer". It's not "guess whether it's okay to throw
> away some
> bits to make an integer".
>
>
> IME The error message itself is to blame here - we are checking
> for a malformed (too many characters) integer
> varbit representation but then reporting that the we somehow got a
> valid integer but that it is "out of range".
>
>
> ​A better reply would be good. Another possibility is for the parser
> to remove unneeded leading zeros.​
>
[...]

I think the latter would be a good idea!

Cheers,
Gavin