Re: allow changing autovacuum_max_workers without restarting

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org, "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: allow changing autovacuum_max_workers without restarting
Date: 2025-04-28 11:55:48
Message-ID: de722583-4ba4-4063-bc41-e20684978116@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 07.01.25 18:23, Nathan Bossart wrote:
> + /*
> + * We chose the default for autovacuum_worker_slots during the
> + * max_connections tests above, but we print a progress message anyway.
> + */
> + printf(_("selecting default \"autovacuum_worker_slots\" ... %d\n"),
> + n_av_slots);
> +

This initdb output seems, well, kinda fake, which it is by its own
admission. Could we do this less fake maybe like this:

selecting default "max_connections", "autovacuum_worker_slots" ... 100, 16

with the actual wait at the "..."?

(It doesn't seem impossible that someone will want to add more default
selecting for various worker or process slots, and this would allow adding
these easily, versus adding more "fake" output lines.)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Shlok Kyal 2025-04-28 12:48:27 Re: Restrict publishing of partitioned table with a foreign table as partition
Previous Message Zhijie Hou (Fujitsu) 2025-04-28 11:33:12 RE: Fix slot synchronization with two_phase decoding enabled