Re: pgsql: PL/Python: Fix potential NULL pointer dereference

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: PL/Python: Fix potential NULL pointer dereference
Date: 2017-12-05 19:16:59
Message-ID: de6d3b84-287a-b943-b5cc-6f5825657c6b@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 11/28/17 13:35, Peter Eisentraut wrote:
> On 11/28/17 11:35, Tom Lane wrote:
>> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>>> PL/Python: Fix potential NULL pointer dereference
>>
>> I do not think it's correct to just "return" out of the middle
>> of a PG_TRY block --- doesn't that result in failing to pop the
>> PG_exception_stack and error_context_stack?
>
> OK, I'll revert and rethink.

How about this instead?

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-PL-Python-Fix-potential-NULL-pointer-dereference.patch text/plain 1.7 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-12-05 19:39:29 pgsql: Fix accumulation of parallel worker instrumentation.
Previous Message Andres Freund 2017-12-05 19:03:04 Re: pgsql: Add some regression tests that exercise hash join code.